Implement requirement from HA PR 138201 #832

bouwew · 2025-02-14T13:03:17Z

Summary by CodeRabbit

Chores
- Updated the registration process for Plugwise devices to enhance compatibility with the latest Home Assistant configuration practices.
- Updated the Home Assistant version in the configuration file to ensure compatibility with the latest features and improvements.
- Added a new section in the changelog to document ongoing developments related to the project.

coderabbitai · 2025-02-14T13:03:25Z

Walkthrough

This pull request updates several Plugwise integration components by replacing the use of AddEntitiesCallback with AddConfigEntryEntitiesCallback in both the import statements and the async_setup_entry function signatures. The internal logic for adding entities remains unchanged, ensuring that entities are still processed as before while now aligning with the configuration entry mechanism. Additionally, the Home Assistant version in hacs.json has been updated.

Changes

File(s)	Change Summary
`custom_components/plugwise/{binary_sensor, button, climate, number, select, sensor, switch}.py`	Updated import statements and `async_setup_entry` signatures to replace `AddEntitiesCallback` with `AddConfigEntryEntitiesCallback`.
`hacs.json`	Updated Home Assistant version from "2025.2.0" to "2025.3.0".
`CHANGELOG.md`	Added a new section "Ongoing" with a downstream HA Core PR 138201, documenting ongoing developments.

Possibly related PRs

Implement various new Core features #668: The changes in the main PR and the retrieved PR are related as both modify the async_setup_entry function in the custom_components/plugwise files to use AddConfigEntryEntitiesCallback and PlugwiseConfigEntry.
Downstreaming Core PR #126896 #750: The changes in the main PR and the retrieved PR are related as both involve updates to the async_setup_entry function's signature, specifically changing the callback type from AddEntitiesCallback to AddConfigEntryEntitiesCallback.
Implement HA Core PR 138039 #829: The changes in the main PR and the retrieved PR are related as both involve updates to the async_setup_entry function signatures to incorporate the PlugwiseConfigEntry type.

Suggested reviewers

CoMPaTech

Poem

In a garden of code, I hop with delight,
Changing callbacks in the dawn’s early light,
From old to new, a switch so sublime,
Each entity added, a reason to chime,
Coding bunnies rejoice—our changes are just right!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7abca1f and 89f7bd2.

📒 Files selected for processing (1)

CHANGELOG.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

CHANGELOG.md

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Setup for HA-core (release/master)
GitHub Check: Setup for HA-core (dev)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

bouwew · 2025-02-14T13:04:36Z

Just for testing now, let's not merge yet, compatible to future HA release.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
❌ Error: Incompatible while testing against released HA-core and required to pass.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
❌ Error: Incompatible while testing against released HA-core and required to pass.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

sonarqubecloud · 2025-03-02T09:22:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions

⚠️ Warning while testing for RELEASED HA-core:

✔️ Success: No problem with testing against dev HA-core.
⚠️ Warning: Incompatible while testing against released HA-core.

bouwew requested a review from a team as a code owner February 14, 2025 13:03

bouwew requested a review from CoMPaTech February 14, 2025 13:03

bouwew added the core-dev-compat Home Assistant Core Release Candidate or Beta compatibility label Feb 14, 2025

bouwew marked this pull request as draft February 14, 2025 13:03

coderabbitai bot approved these changes Feb 14, 2025

View reviewed changes

github-actions bot requested changes Feb 14, 2025

View reviewed changes

bouwew added require-dev-pass Require actions to pass against HA dev-branch (and silently fail on HA master-branch) and removed core-dev-compat Home Assistant Core Release Candidate or Beta compatibility labels Feb 14, 2025

github-actions bot approved these changes Feb 14, 2025

View reviewed changes

CoMPaTech approved these changes Feb 15, 2025

View reviewed changes

bouwew force-pushed the HA-138201 branch from 03e8579 to 0929d32 Compare February 15, 2025 14:44

github-actions bot approved these changes Feb 15, 2025

View reviewed changes

bouwew force-pushed the HA-138201 branch from 0929d32 to b103025 Compare February 19, 2025 14:06

github-actions bot approved these changes Feb 19, 2025

View reviewed changes

bouwew force-pushed the HA-138201 branch from b103025 to 5277e12 Compare February 26, 2025 19:26

github-actions bot approved these changes Feb 26, 2025

View reviewed changes

bouwew added 2 commits March 1, 2025 10:00

Import AddConfigEntryEntitiesCallback

25c3415

Bump HA requirement to 2025.3.0

86c4b27

bouwew force-pushed the HA-138201 branch from 5277e12 to 86c4b27 Compare March 1, 2025 09:00

bouwew added the downstreaming Things that are changed on HA-core side and to be applied to -beta label Mar 1, 2025

github-actions bot approved these changes Mar 1, 2025

View reviewed changes

Update CHANGELOG

7abca1f

github-actions bot approved these changes Mar 1, 2025

View reviewed changes

Improve CHANGELOG

89f7bd2

bouwew marked this pull request as ready for review March 2, 2025 09:21

github-actions bot approved these changes Mar 2, 2025

View reviewed changes

bouwew merged commit 6599bed into main Mar 2, 2025
11 checks passed

bouwew deleted the HA-138201 branch March 2, 2025 09:25

Implement requirement from HA PR 138201 #832

Implement requirement from HA PR 138201 #832

Uh oh!

Conversation

bouwew commented Feb 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

bouwew commented Feb 14, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 2, 2025

Quality Gate passed

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bouwew commented Feb 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)